Skip to content

admin_importChain rpc module#8042

Closed
richardgreg wants to merge 1 commit intoNethermindEth:masterfrom
richardgreg:feature-7814-admin_importChain-rpc
Closed

admin_importChain rpc module#8042
richardgreg wants to merge 1 commit intoNethermindEth:masterfrom
richardgreg:feature-7814-admin_importChain-rpc

Conversation

@richardgreg
Copy link
Contributor

Fixes #7814

Changes

  • List the changes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@LukaszRozmej
Copy link
Member

@richardgreg will close it for now as the PR is just method declaration without implementation and we have too many PR's open to track. Please reopen when it is close to complete and you have some code to review.

@richardgreg
Copy link
Contributor Author

Makes sense

@richardgreg richardgreg deleted the feature-7814-admin_importChain-rpc branch January 17, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement admin_importChain for rpc module

2 participants