Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to .slnx #8195

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Migrate to .slnx #8195

merged 5 commits into from
Feb 12, 2025

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Feb 11, 2025 •
edited
Loading

Changes

  • Migrated from the old and bulky .sln format to the new and readable .slnx XML-based format
  • Updated .NET min version requirement

See Remarks

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

Remarks

Requires .NET v9.0.2+

  • In Visual Studio, go to Tools > Options > Environment > Preview Features and check the "Use Solution File Persistence Model"
  • For Rider, see this

@rubo rubo marked this pull request as ready for review February 11, 2025 22:17
@rubo rubo requested review from LukaszRozmej, MarekM25 and a team as code owners February 11, 2025 22:18
@rubo rubo added the .net label Feb 11, 2025
Marchhill
Marchhill approved these changes Feb 12, 2025
View reviewed changes
.github/workflows/build-tools.yml
- HiveCompare/HiveCompare.slnx
- HiveConsensusWorkflowGenerator/HiveConsensusWorkflowGenerator.slnx
- Nethermind.Tools.Kute/Nethermind.Tools.Kute.slnx
# - SchemaGenerator/SchemaGenerator.slnx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not build this solution?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooo

@benaadams benaadams merged commit 5a74ffc into master Feb 12, 2025
79 checks passed
@benaadams benaadams deleted the feature/slnx branch February 12, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

@asdacap asdacap asdacap approved these changes

@Marchhill Marchhill Marchhill approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@smartprogrammer93 smartprogrammer93 smartprogrammer93 approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25 MarekM25 is a code owner

Assignees
No one assigned
Labels
.net refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rubo @benaadams @asdacap @Marchhill @LukaszRozmej @smartprogrammer93