Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lookup TxDecoder once per block #8438

Merged
merged 5 commits into from
Mar 28, 2025
Merged

Lookup TxDecoder once per block #8438

merged 5 commits into from
Mar 28, 2025

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Mar 28, 2025 •
edited
Loading

Changes

  • Only lookup the TxDecoder once per block, rather than for each tx
  • Optimize ExecutionPayloadParams.ValidateParams
  • Devirtualize shared array pool

Before
image

After
image

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams merged commit 0b07e3c into master Mar 28, 2025
80 checks passed
@benaadams benaadams deleted the tx-decoder branch March 28, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25

@Marchhill Marchhill Awaiting requested review from Marchhill

@marcindsobczak marcindsobczak Awaiting requested review from marcindsobczak

@rubo rubo Awaiting requested review from rubo

@flcl42 flcl42 Awaiting requested review from flcl42

Assignees
No one assigned
Labels
performance is good
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej