Rlp.Encode skip second array creation for length #8440
Merged
+58
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes RLP encoding by reducing unnecessary array allocations and improving memory usage. Key changes include:
- Eliminating a second array creation when serializing lengths.
- Refactoring the SerializeLength method to use spans and uninitialized arrays.
- Introducing the [SkipLocalsInit] attribute on key methods for potential performance benefits.
Gonna take this review summary as summary @rubo 😅 |
LukaszRozmej
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR optimizes RLP encoding by reducing unnecessary array allocations and improving memory usage. Key changes include:
Types of changes
What types of changes does your code introduce?
Testing
Requires testing