Clarify missing messages are Fork Choice

[benaadams]

Contributes to #7575

Changes

• Clarify that the missing messages are ForkChoice, as may be receiving blocks, which makes this message confusingly ambiguous

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

• No

[Copilot]

Pull Request Overview

This PR updates a health check log message to clarify that missing messages are related to ForkChoice rather than generic messages from the consensus client.

• Updated log message wording for clarity.
• Improved alignment with domain terminology regarding block sync.

Comments suppressed due to low confidence (1)

src/Nethermind/Nethermind.HealthChecks/HealthChecksPlugin.cs:215

• [nitpick] Consider using the term 'ForkChoice' without a space to better match domain terminology, and change 'which' to 'that' for improved clarity.

_logger.Warn("Not receiving Fork Choices from the consensus client which are required to sync.");

[Copilot]

Pull Request Overview

This PR aims to clarify the ambiguity in the health check warning message by specifying that the missing messages are ForkChoices.

• Updated the logger warning message to specify "ForkChoices" instead of a generic message.