Skip to content

Refactor/Move the rest of built in rpc modules to DI #8844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Refactor/Move the rest of built in rpc modules to DI #8844

wants to merge 13 commits into from

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jun 24, 2025 •
edited
Loading

  • Move the rest of the built in Rpc modules to DI.
  • Also move some of their dependencies that is simple.
  • Fix randomly failing hive test due to IContextAwareRpcModule being shared.

Types of changes

What types of changes does your code introduce?

  • Refactoring

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Mainnet can sync
  • RPC hive test passed

@asdacap asdacap mentioned this pull request Jun 24, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asdacap