Skip to content

Conversation

Fibonacci747
Copy link

Changes

  • Add dedicated SuicideStorage_Tests method to StateTests class
  • Implement wildcard filtering for SuicideStorage tests using TestsSourceLoader

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

The existing test infrastructure is leveraged to add SuicideStorage test coverage. The changes ensure that SuicideStorage tests run in a dedicated method while preventing duplicate execution in the main test method.

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

Remarks

This PR resolves the TODO comment that was requesting SuicideStorage test coverage. The solution maintains backward compatibility while improving test organization and preventing test duplication.

@LukaszRozmej LukaszRozmej requested a review from flcl42 August 21, 2025 07:58
@LukaszRozmej
Copy link
Member

Aren't those tests already run if you have to filter them out and run separately?

@Fibonacci747
Copy link
Author

Aren't those tests already run if you have to filter them out and run separately?

alright, removed filter and separate method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants