Skip to content

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Sep 1, 2025

With the current commit of src/tests submodule some json are missing for some reason. Let's update the tests and see if they are failing also

Changes

  • Update ethereum/tests version we have as a submodule in src/tests
  • Move Blockchain tests to legacy, as they moved there in src/tests
  • Reflect Legacy status in project names and namespaces
  • Update github workflow accordingly
  • Update pyspec tests to 5.0.0
  • Fix pre EIP-150 tests

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@MarekM25 MarekM25 self-requested a review September 1, 2025 12:20
@flcl42 flcl42 changed the title Update tests to fix missing test jsons Update EthereumTests Sep 4, 2025
@flcl42 flcl42 marked this pull request as ready for review September 5, 2025 11:38
@flcl42 flcl42 requested review from rubo and a team as code owners September 5, 2025 11:38
@flcl42 flcl42 marked this pull request as draft September 5, 2025 13:54
@flcl42 flcl42 marked this pull request as ready for review September 9, 2025 07:21
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there is such discrepancy in added and removed lines of code? +1,885 −3,115
Does this PR reduce amount of test?

@flcl42
Copy link
Contributor Author

flcl42 commented Sep 9, 2025

Why there is such discrepancy in added and removed lines of code? +1,885 −3,115 Does this PR reduce amount of test?

It removes duplicates: blockchain tests were placed into legacy sub-submodule some time ago: https://github.com/ethereum/legacytests/tree/1f581b8ccdc4c63acf5f2c5c1b155c690c32a8eb/Cancun/BlockchainTests, but were not removed from the main submodule. Now we simply have no blockchain but only blockchain block tests: https://github.com/ethereum/tests/tree/develop/BlockchainTests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants