-
Notifications
You must be signed in to change notification settings - Fork 549
Update EthereumTests #9225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update EthereumTests #9225
Conversation
8165178
to
0e6bc0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why there is such discrepancy in added and removed lines of code? +1,885 −3,115
Does this PR reduce amount of test?
It removes duplicates: blockchain tests were placed into legacy sub-submodule some time ago: https://github.com/ethereum/legacytests/tree/1f581b8ccdc4c63acf5f2c5c1b155c690c32a8eb/Cancun/BlockchainTests, but were not removed from the main submodule. Now we simply have no blockchain but only blockchain block tests: https://github.com/ethereum/tests/tree/develop/BlockchainTests |
With the current commit of src/tests submodule some json are missing for some reason. Let's update the tests and see if they are failing also
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?