Make plugin ordering culture-invariant and deterministic #9254
+10
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
reviewed
Sep 7, 2025
LukaszRozmej
reviewed
Sep 7, 2025
Co-authored-by: Lukasz Rozmej <[email protected]>
Co-authored-by: Lukasz Rozmej <[email protected]>
LukaszRozmej
approved these changes
Sep 7, 2025
|
Ok I'm now trying to think does it really make that much sense...
|
@LukaszRozmej Thanks for the thoughtful take. The goal here isn’t performance; it’s to make the behavior fully deterministic and culture‑invariant across machines.
|
LukaszRozmej
reviewed
Sep 8, 2025
Comment on lines
116
to
126
| if (!fHas) | ||
| { | ||
| if (sPos == -1) | ||
| if (!sHas) | ||
| { | ||
| return f.Name.CompareTo(s.Name); | ||
| return string.Compare(f.Name, s.Name, StringComparison.OrdinalIgnoreCase); | ||
| } | ||
|
|
||
| return 1; | ||
| } | ||
|
|
||
| if (sPos == -1) | ||
| if (!sHas) |
There was a problem hiding this comment.
btw you didn't rename the usages of the flags.
|
@LukaszRozmej updated |
|
This somewhat conflicts with #9264, which we need to resolve first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PluginLoader.OrderPluginswith culture-invariant, deterministic comparisons.ToLower()/CompareTowith:StringComparer.OrdinalIgnoreCasefor the ordering mapstring.Compare(..., StringComparison.Ordinal)for tie-break sortingorderMapto avoid linearIndexOflookups.