Make expected to fail hive tests list & fix gas accounting in eth_simulate #9274
+175
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
Hive tests:
In these tests we override precompiles. Geth warms up all precompile addresses before execution, so they charge them as warm access regardless of whether they are actually precompiles.
Hive tests pass if failing tests are in the failing list. This make it easier to catch regressions. Now if Hive action fails we actually have a regression, not just same failing tests that we had before
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
Documentation
Requires documentation update
Requires explanation in Release Notes