Skip to content

Conversation

deffrian
Copy link
Contributor

@deffrian deffrian commented Sep 11, 2025

Fixes Closes Resolves #
Hive tests:

eth_simulateV1/ethSimulate-extcodehash-precompile
eth_simulateV1/ethSimulate-override-ecrecover

In these tests we override precompiles. Geth warms up all precompile addresses before execution, so they charge them as warm access regardless of whether they are actually precompiles.

Hive tests pass if failing tests are in the failing list. This make it easier to catch regressions. Now if Hive action fails we actually have a regression, not just same failing tests that we had before

Changes

  • Adds known-failing-hove-test file with list of hove tests that we know to fail.
  • Extend verification script
  • Warmup precompiles. Not sure if it's good idea. Maybe we should ask geth to change or do something else to cover this case? Some links to geth code: exclude precompiles from AL, warmup precompiles

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@deffrian deffrian requested review from rubo and a team as code owners September 11, 2025 10:05
@deffrian deffrian marked this pull request as draft September 11, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant