Refactor CalculateValueHash for header #9276
Open
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (rlpStreamDecoder is null) | ||
| throw new RlpException($"Decoder not found for {typeof(T).Name}"); | ||
|
|
||
| int totalLength = rlpStreamDecoder.GetLength(item, behaviors); |
| KeccakRlpStream stream = new(); | ||
| IRlpStreamDecoder<T>? rlpStreamDecoder = GetStreamDecoder<T>(); | ||
| if (rlpStreamDecoder is null) | ||
| throw new RlpException($"Decoder not found for {typeof(T).Name}"); |
There was a problem hiding this comment.
Move to ThrowXXX method for performance
| public static ValueHash256 EncodeForHash<T>(T item, RlpBehaviors behaviors = RlpBehaviors.None) | ||
| { | ||
| KeccakRlpStream stream = new(); | ||
| IRlpStreamDecoder<T>? rlpStreamDecoder = GetStreamDecoder<T>(); |
There was a problem hiding this comment.
bit of cost for every hash calculation, but we probably have to pay it
This reverts commit c987460.
LukaszRozmej
approved these changes
Sep 12, 2025
smartprogrammer93
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to make hash calculation more dynamic, since header hash is done through an extension method and cannot be overridden.
An alternative could be to have a virtual method returning
ValueHash256inBlockHeaderitself, and have it return null inBlockHeadersince the decoders doesn't live in Core namespace.