preventing extra empty submission from being added and fixing bug whe…

…re user could not re-edit a submission
Network-Goods · Aug 31, 2023 · a6c4aa2 · a6c4aa2
1 parent 04e6f58
commit a6c4aa2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/components/submission/SubmissionStore.tsx b/src/components/submission/SubmissionStore.tsx
@@ -34,9 +34,21 @@ export const useSubmissionStore = create<SubmissionStore>()((set, get) => ({
       console.error(`ERROR -- rpc call getSubmission failed. submission_id: ${submission_id}`, data);
       return;
     }
+    let parsedLinks;
+    if ("links" in data && typeof data.links === "string") {
+      try {
+        parsedLinks = JSON.parse(data.links);
+      } catch (error) {
+        console.error("Failed to parse links:", error);
+        parsedLinks = [];
+      }
+    }
 
     set({
-      submission: data,
+      submission: {
+        ...data,
+        links: parsedLinks || [],
+      },
       githubHandle: githubHandle,
       fetching: false,
     });

diff --git a/src/server/routes/admin/importCSVData.ts b/src/server/routes/admin/importCSVData.ts
@@ -54,7 +54,8 @@ export const importCSVData = adminProcedure
       createdEvaluationFields.push(evaluationField);
     }
 
-    for (const row of parsedData) {
+    const validData = parsedData.filter((row: any) => row.project_name); //preventing empty rows from being added
+    for (const row of validData) {
       const submissionId = uuid();
       const submissionData = {
         id: submissionId,