Add a flag for intanrawio indicating whether intan hardware has already applied a notch filter to raw data #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a `notch_filter_applied` info box as a boolean to indicate whether the Intan hardware applied the notch filter. For both rhs and rhd I just added the check at the bottom before the return since we need to check both whether the `notch_filter_mode` > 0 and that the version is >= 3.0. I couldn't think of a way to fit it during the notch filter check without adding conditions into other functions which would slow everything down. It just means that the `notch_filter_applied` would be out of order compared to the other keys.
fixed rhd support. I didn't change support in doc string for rhs since I don't know what changes may have occurred in 2.x.
JuliaSprenger
approved these changes
Feb 27, 2023
deleted extra spaces as suggested
|
Thanks for the changes, they look good to me. The failing tests unrelated (#1227) to the changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first stab at incorporating a flag so that users can see whether or not their data has already had a notch filter applied. I couldn't think of a way to get it incorporated during the flow of the rest of the script, so I added the check right before the return to generate the flag.
@samuelgarcia