Add joblib dependency #1226
Merged
Add joblib dependency #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joblib is used in BaseRawIO.__init__ and is a hard dependency if caching is used (fixes NeuralEnsemble#1224).
Closed
There was a problem hiding this comment.
I would not restrict to the most recent joblib version as this might cause version conflicts on some systems. joblib version 1.0.0 was released end of 2020, which might be a better minimum requirement. We try to roughly follow the Numpy policy for version dependencies.
@joschaschmiedt Or did you notice problems using joblib<1.2.0?
Co-authored-by: Julia Sprenger <[email protected]>
Co-authored-by: Julia Sprenger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
joblib is used in
BaseRawIO.__init__and is a hard dependency if caching is used (#1224). I therefore added it to the project's dependencies.