Skip to content

Conversation

samuelgarcia
Copy link
Contributor

@samuelgarcia
Copy link
Contributor Author

@DradeAW can you test this ?

@DradeAW
Copy link

DradeAW commented Apr 3, 2023

I now have a different error:

recording = se.SpikeGLXRecordingExtractor(".", stream_name="imec0.ap")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/export/home1/users/nsr/wyngaard/dev/spikeinterface/spikeinterface/spikeinterface/extractors/neoextractors/spikeglx.py", line 67, in __init__
    probe = pi.read_spikeglx(meta_filename)
  File "/export/home1/users/nsr/wyngaard/dev/spikeinterface/probeinterface/probeinterface/io.py", line 1119, in read_spikeglx
    meta = parse_spikeglx_meta(meta_file)
  File "/export/home1/users/nsr/wyngaard/dev/spikeinterface/probeinterface/probeinterface/io.py", line 1149, in parse_spikeglx_meta
    key, val = line.split('=')
ValueError: too many values to unpack (expected 2)

I'm guessing this is because of the 3rd line in the meta file containing multiple = signs?

@samuelgarcia
Copy link
Contributor Author

This is in probeinterface you need to update probeinterface I think

@DradeAW
Copy link

DradeAW commented Apr 3, 2023

Same problem, just the line numbers that are different:

recording = se.SpikeGLXRecordingExtractor(".", stream_name="imec0.ap")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/export/home1/users/nsr/wyngaard/dev/spikeinterface/spikeinterface/spikeinterface/extractors/neoextractors/spikeglx.py", line 67, in __init__
    probe = pi.read_spikeglx(meta_filename)
  File "/export/home1/users/nsr/wyngaard/dev/spikeinterface/probeinterface/probeinterface/io.py", line 1133, in read_spikeglx
    meta = parse_spikeglx_meta(meta_file)
  File "/export/home1/users/nsr/wyngaard/dev/spikeinterface/probeinterface/probeinterface/io.py", line 1163, in parse_spikeglx_meta
    key, val = line.split('=')
ValueError: too many values to unpack (expected 2)

@samuelgarcia
Copy link
Contributor Author

Does the neo.SpikeGLXIO working ?

@DradeAW
Copy link

DradeAW commented Apr 3, 2023

Yes, both neo.rawio.SpikeGLXRawIO().parse_header() and neo.io.SpikeGLXIO seem to be working :)

@samuelgarcia
Copy link
Contributor Author

So we need to make a equivalent patch in probeinterface!

@JuliaSprenger JuliaSprenger merged commit f68c29a into NeuralEnsemble:master Apr 3, 2023
@JuliaSprenger JuliaSprenger added this to the 0.12.1 milestone Apr 3, 2023
@alejoe91
Copy link
Contributor

alejoe91 commented Apr 4, 2023

@alejoe91
Copy link
Contributor

alejoe91 commented Apr 4, 2023

I think it messes up with the nidq stream name...

@JuliaSprenger
Copy link
Member

@samuelgarcia Do you mind looking into fixing also this?

JuliaSprenger added a commit that referenced this pull request Apr 4, 2023
@JuliaSprenger JuliaSprenger modified the milestones: 0.12.1, 0.13.0 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants