Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not allow Groups to contain Segments #1314

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

apdavison
Copy link
Member

as proposed in #1026, which this PR partially replaces

@apdavison apdavison added the Core label Jul 27, 2023
@apdavison apdavison added this to the 0.13.0 milestone Jul 27, 2023
@apdavison
Copy link
Member Author

I know we've discussed it several times, but it's not clear to me what the disadvantages are of allowing grouping of Segments. Does it break anything?

The use case I have in mind is where a stimulus is repeated several times, and each recording is in a separate Segment, but then there is some artefact during one of the segments, so we want to group the "good" segments. (A similar thing could of course be achieved using annotations.)

@apdavison apdavison mentioned this pull request Jul 27, 2023
@JuliaSprenger JuliaSprenger merged commit 4ef2801 into NeuralEnsemble:master Dec 14, 2023
39 checks passed
@apdavison apdavison deleted the no-segments-in-group branch February 2, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants