Skip to content

Conversation

h-mayorquin
Copy link
Contributor

@h-mayorquin h-mayorquin commented Sep 4, 2024

This PR is not mean to be merged but to add a concrete implementation to suggest in #1544. This PR probably is incomplete and it has errors.

The idea here is that the BaseRawIO will add post parsing logic to modify the signal_streams and signal_channels headers by adding the buffer id if they are not in the new type yet. Same for signal_channels where the buffer id will be added as an extra column. In all of those cases the buffer_id is just a carbon copy of the stream_id.

This approach should enable the following workflow and progression plan:

  1. In one sweep all the classess should have the correct dtype for the header avoiding an intermediate state of the library where not all the formats have the same dtype for the headers.
  2. We can then approach each format piece-wise and assign the proper buffer ids and separate the streams logically.
  3. Once we are done with all the formats we can eliminate the post parsing code here and everything should be clean.

@h-mayorquin
Copy link
Contributor Author

OK, so Sam decided to do this in one sweep. Let's close this once we are finished with #1544.

@zm711
Copy link
Contributor

zm711 commented Oct 11, 2024

We said we would close with the merge of #1544. Reopen if needed Heberto.

@zm711 zm711 closed this Oct 11, 2024
@h-mayorquin h-mayorquin deleted the enchance_neo_format branch October 11, 2024 18:03
@h-mayorquin
Copy link
Contributor Author

Thanks for closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants