Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlexonIO: Fix another plexon overflow #1585

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

zm711
Copy link
Contributor

@zm711 zm711 commented Oct 17, 2024

@h-mayorquin could I have you give this a quick read through. Then we can have Sam merge it later.

Error here:

https://readthedocs.org/projects/neo/builds/25985599/

Copy link
Contributor

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

I wonder how comes this failed now and not before and why this is being executed on the read the docs : /

@zm711
Copy link
Contributor Author

zm711 commented Oct 17, 2024

I wonder how comes this failed now and not before

I've been messing with CI stuff so maybe I changed over some cache thing or version thing. Who knows....

why this is being executed on the read the docs : /

To show off Neo with real data. I suggested simulated in the past and the point was this can work with real data so it should show real data.

Thanks Heberto!

@zm711 zm711 added this to the 0.13.4 milestone Oct 18, 2024
@zm711 zm711 changed the title Fix another plexon overflow PlexonIO: Fix another plexon overflow Oct 18, 2024
@zm711
Copy link
Contributor Author

zm711 commented Oct 18, 2024

Just for your info Heberto RTD changed something recently so maybe this precipitated the issue (it shouldn't have but who knows at this point):
https://about.readthedocs.com/blog/2024/07/addons-by-default/#how-to-opt-in-to-addons-now

@zm711 zm711 merged commit b17979a into NeuralEnsemble:master Oct 18, 2024
3 checks passed
@zm711 zm711 deleted the plexon-overflow branch October 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants