-
Notifications
You must be signed in to change notification settings - Fork 257
Separate sync as its own stream in SpikeGLXRawIO
#1683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate sync as its own stream in SpikeGLXRawIO
#1683
Conversation
I am OK with this. Maybe we should have Do we need a spikeinterface change or not ? |
So you want an option that loads the sync channels but does not throw the warning? As in, the users know that it will be deprecated but they want to keep using it without warning until we do. Is that correct?
I think for this case just a deprecation warning as there are always at least two streams in SpikeGLX. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question but then this is good by me?
for me I don't see the need of the None mechanism. People have been using this for a while so if they say True we should warn them that this is changing and the default is False so no warning.
Everything is ok for me. |
Thanks for the review. |
Same as #1668. Should come after it.