Skip to content

Separate sync as its own stream in SpikeGLXRawIO #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 19, 2025

Conversation

h-mayorquin
Copy link
Contributor

@h-mayorquin h-mayorquin commented Apr 6, 2025

Same as #1668. Should come after it.

@h-mayorquin h-mayorquin marked this pull request as ready for review April 10, 2025 14:58
@samuelgarcia
Copy link
Contributor

I am OK with this.

Maybe we should have load_sync_channel=None being the semantic not trigerring warning before the removal of this option.

Do we need a spikeinterface change or not ?

@h-mayorquin
Copy link
Contributor Author

Maybe we should have load_sync_channel=None being the semantic not trigerring warning before the removal of this option.

So you want an option that loads the sync channels but does not throw the warning? As in, the users know that it will be deprecated but they want to keep using it without warning until we do. Is that correct?

Do we need a spikeinterface change or not ?

I think for this case just a deprecation warning as there are always at least two streams in SpikeGLX.

Copy link
Contributor

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but then this is good by me?

for me I don't see the need of the None mechanism. People have been using this for a while so if they say True we should warn them that this is changing and the default is False so no warning.

@samuelgarcia
Copy link
Contributor

Everything is ok for me.
No worry about the none stuff.

@zm711 zm711 merged commit 1e09dd7 into NeuralEnsemble:master May 19, 2025
5 checks passed
@zm711 zm711 added this to the 0.14.2 milestone May 19, 2025
@h-mayorquin h-mayorquin deleted the spikeglx_sync_separate branch May 20, 2025 20:35
@h-mayorquin
Copy link
Contributor Author

Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants