Skip to content

Better error intan when missing files in the "one-file-per-signal" type. #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

h-mayorquin
Copy link
Contributor

From the discussion on #1693, @zm711

image

@h-mayorquin
Copy link
Contributor Author

Maybe there are some missing ones that are acceptable. But I think we can start here and be explicit which is better.

@h-mayorquin
Copy link
Contributor Author

So we have some tests that don't have digital output and supply voltage.

image

What else is possible not to have?

@zm711
Copy link
Contributor

zm711 commented Apr 24, 2025

I think this is a tough check to make carefully. For one-file-per-channel you can basically shut anything off. For one-file-per-signal that are certain combination that have to show up together but you could shut off dig in /dig out, aux channels. So I think don't think we have a realistic core. I think we should pull the info from the header and whatever the header says is enabled we raise an error no? We do that when we read the header. Most things have a boolean check to see if that signal is enabled?

@zm711
Copy link
Contributor

zm711 commented Apr 24, 2025

Look at line 1185 for the check I'm referring to. We see that the signal is enable. Then we could use that information for the formats I think. Maybe you could try an implementation with that instead?

@h-mayorquin
Copy link
Contributor Author

For one-file-per-signal that are certain combination that have to show up together but you could shut off dig in /dig out, aux channels. So I think don't think we have a realistic core.

Yeah, this is the case that I want to cover. one-file-per-channel seems too complicated at the moment but might do it later.

I think we should pull the info from the header and whatever the header says is enabled we raise an error no? We do that when we read the header. Most things have a boolean check to see if that signal is enabled?

Yes, this is the way. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants