-
Notifications
You must be signed in to change notification settings - Fork 257
BlackRock: shape parameter for memap #1705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise this seems fine to me.
@zm711 I'll still do some checks before merging this, changing it to draft for now |
the resulting extracted data seem to be correct |
OK for me. |
Co-authored-by: Zach McKenzie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good by me. Will merge once tests pass :)
tests seem to be breaking for plexon at python 3.9, but apparently not related to the changes here |
Yeah this was a previous issue plexon2 only works on windows so we are trying to run it through wine and when running it through wine it often fails to open the file (even the plexon dev's don't know why that happens. I'll try rerunning one more time and if it still fails I'll merge then open an issue to troubleshoot. Normally a re-run or two fixes it. EDIT: on our main branch it appears to have failed on 3.12 so I don't think this is a python version issue. maybe a wine issue or maybe the normal flakiness of the file failing to open. |
Merging as the test failures are unrelated to this PR. I opened issue #1707 for us to figure out this flakiness and tests passed before the comment (documentation not code change) was added :) |
Added a shape parameter to avoid the error #1704
Fix #1704