W3D3 - fix for deprecated numpy method and minor change to avoid OOM crashes #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on downloading a custom set of data and packages as a bundle. Rather than attempting to fork, fix, and reprocess the code & archive, opted to just make the numpy code change directly to the downloaded code before import.
The OOM issue has to do with the cosine similarity function solution to exercise 2.1.1. There just isn't enough CUDA memory in a T4 instance to run the solution as implemented along with the whole process that goes into the plotting function. If you use CPU, the runtime will crash. The only place this custom solution is tried out is in the directly following interactive exercise, and simply not setting a custom function (which every other call to this method does) works just fine. As there is a tiny little test method specifically for this exercise already to verify it works, I think this is the best we can do for now.