Skip to content

[fix] 월 기준 선물 획득 로직 아예 삭제 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jeongminyooa merged 1 commit into from
Jul 6, 2025
Merged

[fix] 월 기준 선물 획득 로직 아예 삭제 #104

Jeongminyooa merged 1 commit into from
Jul 6, 2025

Conversation

@Jeongminyooa
Copy link
Collaborator

@Jeongminyooa Jeongminyooa commented Jul 6, 2025

#️⃣96

📝작업 내용

  • 꾸미기 아이템 소장 기간에 대한 로직 수정 중 누락 사항 반영
  1. 사용자가 가지고 있는 꾸미기 아이템 개수 확인 쿼리가 'notOpened' 기준으로 되어 있어 0개가 집계되는 이슈 -> findAllByUser 조건으로 수정
  2. 피드백에서 NotOpen 조회 시 월별 기간으로 집계하고 있어 해당 부분에서 기간 삭제된 쿼리로 변경

@Jeongminyooa Jeongminyooa requested a review from k906506 July 6, 2025 11:02
@Jeongminyooa Jeongminyooa self-assigned this Jul 6, 2025
@Jeongminyooa Jeongminyooa added the bug Something isn't working label Jul 6, 2025
@github-actions
Copy link

github-actions bot commented Jul 6, 2025

Unit Test Results

1 tests   1 ✔️  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit a994452.

k906506
k906506 approved these changes Jul 6, 2025
View reviewed changes
Copy link
Collaborator

@k906506 k906506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인!

@Jeongminyooa Jeongminyooa merged commit 4b5cd6d into dev Jul 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k906506 k906506 k906506 approved these changes

Assignees

@Jeongminyooa Jeongminyooa

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jeongminyooa @k906506