1차 MVP 기능 개선 #30
Merged
1차 MVP 기능 개선 #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
닉네임 최대 글자 제한
This reverts commit ba523ea.
Collaborator
Jeongminyooa
left a comment
Jeongminyooa
left a comment
There was a problem hiding this comment.
코드 확인했으!!! 코멘트 한번만 확인해줘~ 넘 고생많았다....
| @Getter | ||
| @Setter | ||
| public class HttpStatusDTO<T> { | ||
| private int statusCode; |
Collaborator
There was a problem hiding this comment.
추후에 http status에 쓰이는 변수들 enum으로 관리 가능하게 재정의하면 좋을 듯!
Collaborator
Author
There was a problem hiding this comment.
2.0 배포하면서 추가로 작업할게!
| package donmani.donmani_server.appversion.entity; | ||
|
|
||
| public enum PlatformType { | ||
| Android, |
Collaborator
There was a problem hiding this comment.
대문자로 통일하는게 낫지 않을까? e.g. AOS, IOS 등
Collaborator
Author
There was a problem hiding this comment.
|
|
||
| @GetMapping("/calendar/{userKey}") | ||
| public ResponseEntity<ExpenseResponseDTO> getExpensesCalendar( | ||
| @GetMapping("api/v1/expenses/calendar/{userKey}") |
Collaborator
There was a problem hiding this comment.
서버 사이드는 버전 정책 어떻게 가져갈지 한번 얘기해봐야겠다
Collaborator
Author
There was a problem hiding this comment.
좋아!
지금 기존 API 살리느라 클래스(DTO), 메소드, URL에 V1, V2 막 섞여있는데, 클라쪽 API 붙이는 작업 마치면 이것도 다시 손볼게
| userRepository.save(newUser); | ||
|
|
||
| UserRegisterResponseDTO response = new UserRegisterResponseDTO(user.getUserKey(), user.getName()); | ||
| response = new UserRegisterResponseDTO(true, newUser.getUserKey(), newUser.getName()); |
Collaborator
There was a problem hiding this comment.
여기서는 왜 builder를 안 쓴건쥐 궁금해!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
[feature-29] 1차 MVP 기능 개선 #29
📝 작업 내용