디스코드 웹훅 연결 #52
Merged
디스코드 웹훅 연결 #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Jeongminyooa
left a comment
Jeongminyooa
left a comment
There was a problem hiding this comment.
모두 확인 완료!! 코멘트 달아놨어~ 너무 고생많았다아... 이것저것 디테일하게 수정한 부분들이 많네..
| private Long userId; | ||
|
|
||
| private LocalDateTime createdAt; | ||
| private LocalDateTime createdAt; // 사용자가 기록하려는 일자 -> 어제 기록을 오늘 등록한 경우 어제일자로 들어감 |
Collaborator
There was a problem hiding this comment.
이거 나중에 헷갈릴 수도 있겠다. recordDate 같은거로 네이밍해도 좋을듯!
| - 2025.04.16 | ||
| - 생성일자, 최종변경일자 칼럼 추가 | ||
| */ | ||
| private LocalDateTime createdDate; // 서버에 기록된 일자 |
Collaborator
There was a problem hiding this comment.
추후 BaseEntity로 따서, createdDate랑 updateDate 엔터티마다 동일 수준으로 관리되게 하면 되겠다
| } | ||
|
|
||
| @PutMapping("api/v1/notice/enable/{userKey}") | ||
| public ResponseEntity<HttpStatusDTO<UpdateUserNoticeEnableRequestDTO>> updateUserNoticeEnableV1( |
Collaborator
There was a problem hiding this comment.
알림수신 관련 워딩 notice로 나도 통일할게
| private final WebHookRepository webHookRepository; | ||
| private final WebClient webClient; | ||
|
|
||
| private final String webhookUrl = "https://discord.com/api/webhooks/1363380639302156368/wESM5jCLC2irACyRbhV2LmOrfSVXXaBhlGc_2PLaMvbmeukL5D7-1JA2IjukHuoYMTWY"; |
Collaborator
There was a problem hiding this comment.
webhook url yml로 관리 안되고 링크 그대로 올려도 상관없나? 보안 이슈 따로 없는건가 싶어서유
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용