Skip to content

Conversation

@Jeongminyooa
Copy link
Collaborator

@Jeongminyooa Jeongminyooa commented Jun 15, 2025

๐Ÿ“์ž‘์—… ๋‚ด์šฉ

  • ๋ฌธ์ œ : ๋ณ„ํ†ต์ด ๊ธฐ๋ณธ ์•„์ดํ…œ์ด 2๋ฒˆ ์ ์šฉ๋˜๋Š” ์˜ค๋ฅ˜ (๋™๊ธฐ/๋น„๋™๊ธฐ ์ด์Šˆ์ธ์ค„ ์•Œ์•˜์œผ๋‚˜ ํ•ด๋‹น ์กฐ์น˜ ์ดํ›„์—๋„ ๋™์ผ ํ˜„์ƒ ๋ฐœ์ƒ)

  • ๋ณ„ํ†ต์ด ๊พธ๋ฏธ๊ธฐ ๋ถˆ๋Ÿฌ์˜ค๊ธฐ ๋กœ์ง์—๋งŒ default item init ๋˜๋„๋ก ์ˆ˜์ •
    (๊ธฐ์กด : ๋ณ„ํ†ต์ด ๊พธ๋ฏธ๊ธฐ ์ €์žฅ ์‹œ ์ €์žฅ๋œ ์•„์ดํ…œ์ด ์—†๋‹ค๋ฉด init ์ ์šฉ๋˜์–ด ์ค‘๋ณต ์ ์šฉ๋˜์—ˆ์„ ํ™•๋ฅ  ์žˆ์Œ.)

  • bgm์ด 7์›” ์ค‘ ์˜คํ”ˆ ์ผ์ •์œผ๋กœ ๋ณ€๊ฒฝ๋˜๋ฉฐ ๊ด€๋ จ ๋กœ์ง ์‚ญ์ œ

  • ์‹ฑํฌ ๋™์ž‘ ๋กœ์ง ์‚ญ์ œ


์ถ”๊ฐ€ ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • default ์•„์ดํ…œ์€ ๋งค์›”, ๋ชจ๋“  ์œ ์ €์—๊ฒŒ ๊ณตํ†ต ์‚ฌํ•ญ์ด๋ฏ€๋กœ user_item ๋ฐ user_equipped_item ํ…Œ์ด๋ธ”์—์„œ ๊ด€๋ฆฌ๋˜์ง€ ์•Š๊ณ  ์„œ๋น„์Šค ๋ ˆ์ด์–ด์—์„œ๋งŒ ๋ถ„๊ธฐ ์กฐ๊ฑด์— ๋”ฐ๋ผ ์กฐํšŒ๋˜๋„๋ก ์ˆ˜์ •
    • reward item ์—์„œ๋Š” ๊ด€๋ฆฌ๋˜๊ณ  ์žˆ๊ธฐ ๋•Œ๋ฌธ์— ์ €์žฅ ๋ฐ ์กฐํšŒ ๋กœ์ง์—์„œ ํŠน์ด์‚ฌํ•ญ x
  • ํš๋“ํ•˜์ง€ ์•Š์€ ์•„์ดํ…œ ํ™•์ธ ๋กœ์ง์—์„œ UserItem๊ณผ RewardItem์ด ๋™๋“ฑ ๋น„๊ต๋˜๋Š” ์˜ค๋ฅ˜ ๋ฐœ๊ฒฌ -> id๋กœ ๋น„๊ต๋˜๋„๋ก ์ˆ˜์ •

@Jeongminyooa Jeongminyooa requested a review from k906506 June 15, 2025 10:59
@Jeongminyooa Jeongminyooa self-assigned this Jun 15, 2025
@Jeongminyooa Jeongminyooa added the bug Something isn't working label Jun 15, 2025
@github-actions
Copy link

github-actions bot commented Jun 15, 2025

Unit Test Results

1 testsโ€‚โ€ƒโ€ƒ1 โœ”๏ธโ€ƒโ€ƒ0s โฑ๏ธ
1 suitesโ€ƒโ€ƒ0 ๐Ÿ’ค
1 filesโ€„โ€‚โ€ƒโ€ƒ0 โŒ

Results for commit c6a55cf.

โ™ป๏ธ This comment has been updated with latest results.

Copy link
Collaborator

@k906506 k906506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ–ˆ์–ด!!


List<RewardItem> availableRewards = allItems.stream()
.filter(item -> !acquiredItems.contains(item))
.filter(item -> !acquiredItemIds.contains(item.getId()))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ‘๐Ÿ‘

acquiredItems.stream()
.map(item -> {
// 3์ผ ์ด๋‚ด ํš๋“ํ•œ Item
boolean newAcquired = item.getAcquiredAt().isAfter(threeDaysAgo) ? true : false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3์ผ ๋™์•ˆ ๋…ธํ‹ฐํ•ด์ฃผ๋Š” ๊ฑด ์‚ฌ๋ผ์ง„๊ฑด๊ฐ€?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋…ธ๋…ธ! 185 ๋ผ์ธ์— ์žˆ์–ด!

@Jeongminyooa Jeongminyooa merged commit 936a9cd into dev Jun 15, 2025
2 checks passed
@Jeongminyooa Jeongminyooa deleted the hotfix-81 branch June 16, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants