Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonstrup
reviewed
Feb 19, 2025
| final Map<Keyword, BigDecimal> weightMap = calculateKeywordWeights(metricsMap); | ||
|
|
||
| return ValueReports.report(weightMap, metricsMap, submissions); | ||
| return ValueReports.report(metricsMap, submissions); |
There was a problem hiding this comment.
넵
처음에는 필요하다고 생각해서 추가했는데 생각해보니 키워드별로 점수를 따로 계산하니까 필요가 없더라구요 😅
Test Results106 tests 104 ✅ 4s ⏱️ Results for commit 78b5823. ♻️ This comment has been updated with latest results. |
- 온보딩 게임 같은 단계별 선택지가 존재하는 설문의 경우, 키워드는 같지만 점수만 다른 옵션들이 존재함 - 옵션을 점수 내림차순하여 전달하면 해당 설문에서 나올 수 있는 최대, 최소 점수를 계산하여 반환
|
기획과 조금 맞지 않고, 서브 점수를 효과적으로 사용할 수 없어 다른 방법을 채택했습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 개요
가치관 분석 리포트 로직 리팩토링
작업 사항
+)
ScoreEvaluator테스트도 작성하려다가ValueReports값을 단순 반환하는 느낌이라 작성하지 않았습니다!