Skip to content

navigation-compose 2.8.5 마이그레이션 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eshc123 merged 9 commits into from
Jan 22, 2025
Merged

navigation-compose 2.8.5 마이그레이션 #87

eshc123 merged 9 commits into from
Jan 22, 2025

Conversation

@eshc123
Copy link
Member

@eshc123 eshc123 commented Jan 10, 2025 •
edited
Loading

주요 내용

  • androidx.navigation:navigation-compose 버전을 2.8.5으로 올리면서 String으로 되어있던 route들을 RouteModel등의 클래스로 수정
  • ViewModel 인수 전달은 savedStateHandle.toRoute 을 통해 전달
  • RouteModel 에 MainTabRoute를 정의하였습니다. 이번 PR과 무관한 내용일 수 있지만 RouteModel을 수정하면서 HistoryRouteModel을 비롯한 MainTabRoute를 정리하였습니다.

@eshc123 eshc123 requested a review from bywindow January 10, 2025 12:41
@eshc123 eshc123 self-assigned this Jan 10, 2025
bywindow
bywindow approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@bywindow bywindow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요~!!~

@eshc123 eshc123 merged commit 8e2f8d6 into dev Jan 22, 2025
1 check passed
@eshc123 eshc123 deleted the refactor/navigation-compose-migration branch January 22, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bywindow bywindow bywindow approved these changes

Assignees

@eshc123 eshc123

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eshc123 @bywindow