Skip to content

Commit 57fdcca

Browse files
claude[bot]github-actions[bot]claude
authored
Maintenance: PopularMemeService - Apply Dependency Inversion Principle (#97)
Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Claude <[email protected]>
1 parent 793dee6 commit 57fdcca

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/main/java/spring/memewikibe/application/PopularMemeService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
public class PopularMemeService {
1616

1717
private final InMemoryPopularMemeCache inMemoryPopularMemeCache;
18-
private final MemeAggregationLookUpServiceImpl memeAggregationLookUpServiceImpl;
18+
private final MemeAggregationLookUpService memeAggregationLookUpService;
1919
private final MemeLookUpService memeLookUpService;
2020

2121
public List<MemeSimpleResponse> getTopPopularMemes() {
@@ -24,7 +24,7 @@ public List<MemeSimpleResponse> getTopPopularMemes() {
2424
if (cachedMemeIds.size() < inMemoryPopularMemeCache.getTargetSize()) {
2525
log.debug("Cache is not full ({}/<{}), falling back to DB",
2626
cachedMemeIds.size(), inMemoryPopularMemeCache.getTargetSize());
27-
List<MemeSimpleResponse> popularMemes = memeAggregationLookUpServiceImpl.getMostPopularMemes();
27+
List<MemeSimpleResponse> popularMemes = memeAggregationLookUpService.getMostPopularMemes();
2828
List<Long> memeIds = popularMemes.stream()
2929
.map(MemeSimpleResponse::id)
3030
.toList();
@@ -41,7 +41,7 @@ public List<MemeSimpleResponse> getTopPopularMemes() {
4141
@PostConstruct
4242
public void warmUpCache() {
4343
try {
44-
List<MemeSimpleResponse> popularMemes = memeAggregationLookUpServiceImpl.getMostPopularMemes();
44+
List<MemeSimpleResponse> popularMemes = memeAggregationLookUpService.getMostPopularMemes();
4545
List<Long> memeIds = popularMemes.stream()
4646
.map(MemeSimpleResponse::id)
4747
.toList();

src/main/java/spring/memewikibe/application/SharedMemeScheduleCacheService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public class SharedMemeScheduleCacheService {
2424

2525
private volatile MostSharedMemes cachedData;
2626

27-
public SharedMemeScheduleCacheService(MemeAggregationLookUpServiceImpl memeAggregationLookUpService, TimeProvider timeProvider) {
27+
public SharedMemeScheduleCacheService(MemeAggregationLookUpService memeAggregationLookUpService, TimeProvider timeProvider) {
2828
this.memeAggregationLookUpService = memeAggregationLookUpService;
2929
this.timeProvider = timeProvider;
3030
}

0 commit comments

Comments
 (0)