Skip to content

Maintenance: MemeAggregationServiceImpl - Eliminate code duplication #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
claude wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Maintenance: MemeAggregationServiceImpl - Eliminate code duplication #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions src/main/java/spring/memewikibe/application/MemeAggregationServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
import spring.memewikibe.infrastructure.MemeViewLogRepository;
import spring.memewikibe.support.error.MemeWikiApplicationException;

import java.util.function.Consumer;
import java.util.function.Function;

import static spring.memewikibe.support.error.ErrorType.MEME_NOT_FOUND;

@RequiredArgsConstructor
Expand All @@ -32,25 +35,19 @@ public class MemeAggregationServiceImpl implements MemeAggregationService {
@Override
@Transactional
public void increaseMemeViewCount(Long memeId) {
Meme meme = getMemeBy(memeId);
memeViewLogRepository.save(MemeViewLog.of(meme));
inMemoryPopularMemeCache.onMemeViewed(memeId);
recordMemeActivity(memeId, MemeViewLog::of, memeViewLogRepository::save, inMemoryPopularMemeCache::onMemeViewed);
}

@Override
@Transactional
public void increaseMakeCustomMemeCount(Long memeId) {
Meme meme = getMemeBy(memeId);
memeCustomLogRepository.save(MemeCustomLog.of(meme));
inMemoryPopularMemeCache.onMemeCustomized(memeId);
recordMemeActivity(memeId, MemeCustomLog::of, memeCustomLogRepository::save, inMemoryPopularMemeCache::onMemeCustomized);
}

@Override
@Transactional
public void increaseShareMemeCount(Long memeId) {
Meme meme = getMemeBy(memeId);
memeShareLogRepository.save(MemeShareLog.of(meme));
inMemoryPopularMemeCache.onMemeShared(memeId);
recordMemeActivity(memeId, MemeShareLog::of, memeShareLogRepository::save, inMemoryPopularMemeCache::onMemeShared);
}

@Async
Expand All @@ -60,6 +57,18 @@ public void handleMemeViewed(MemeViewedEvent event) {
increaseMemeViewCount(event.memeId());
}

private <T> void recordMemeActivity(
Long memeId,
Function<Meme, T> logFactory,
Consumer<T> logSaver,
Consumer<Long> cacheUpdater
) {
Meme meme = getMemeBy(memeId);
T log = logFactory.apply(meme);
logSaver.accept(log);
cacheUpdater.accept(memeId);
}

private Meme getMemeBy(Long memeId) {
return memeRepository.findById(memeId).orElseThrow(() -> new MemeWikiApplicationException(MEME_NOT_FOUND));
}
Expand Down