Skip to content

Conversation

@sikkzz
Copy link
Collaborator

@sikkzz sikkzz commented Jan 27, 2025

💡 변경사항 & 이슈

typography, color 설정

✍️ 관련 설명

reset css 설정
typography, color 설정

Button 관련 코드들은 이후 삭제 예정 (테스트용으로 작성)

⭐️ Review point

  • 설정 관련해서 더 좋은 방법이나 의견이 있는지
  • color랑 font 변수 네이밍 의견 (현재는 framer 보고 임의로 작성한 상태)
  • mixin 관련 추가하고 싶은 util 있는지

내가 원래 css-in-css를 잘 안써서 아는 게 별로 없다보니 서칭 좀 하면서 설정 해봤는데 더 좋은 방법이 있거나 의견 있으면 편하게 달아줘!

📷 Demo

.

@sikkzz sikkzz requested a review from lgrin-byte January 27, 2025 15:48
@sikkzz sikkzz self-assigned this Jan 27, 2025
@sikkzz sikkzz linked an issue Jan 27, 2025 that may be closed by this pull request
1 task
@sikkzz sikkzz changed the title Feat/#5 [Feat/#5] typography, color 설정 Jan 27, 2025
@sikkzz sikkzz added Feature new feature and removed enhancement labels Jan 27, 2025
Copy link
Member

@lgrin-byte lgrin-byte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넘 잘해둬서 할 게 없는,,, 저 머할까여,,,🥲

@sikkzz sikkzz merged commit bbbbf32 into develop Jan 29, 2025
1 check passed
@sikkzz sikkzz deleted the feat/#5 branch January 29, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] typography, color 설정

3 participants