[Feat/#7] 공통 아이콘 컴포넌트 제작 #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
|
🧷 Storybook: https://6798a432c75b75bf6b81bc26-vrbspfesvf.chromatic.com/ ⏰ Update: 2025년 01월 29일 23시 41분 |
sikkzz
force-pushed
the
feat/#7
branch
2 times, most recently
from
9e36ea2 to
50ce944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 변경사항 & 이슈
공통 아이콘 컴포넌트 제작
아이콘 컴포넌트 스토리북 추가
스토리북 자동 배포 github action 추가
✍️ 관련 설명
아이콘을 그때그때 import해서 사용하니까 통일성도 없어지고 유지보수가 힘들었어서 공통으로 제작했어
위 형식으로 구성했고 지금은 framer에 있는거만 그대로 추가했는데 이후에 변동되는거 있으면 관리해주면 될 거 같아
추가적으로 storybook도 추가했으니 확인해보면 될 듯! 아래 demo 사진도 스토리북이야
https://6798a432c75b75bf6b81bc26-nwsyacgozw.chromatic.com/?path=/story/example-icon--all-icons
스토리북 자동 배포도 github action으로 걸어놨는데 작동 확인해봐야 할 거 같고, 스토리북 코드에서 변동 사항이 없으면 작동 안하게 설정했는데 이후 PR에서 제대로 작동 안하면 확인 한번 더 해볼게
⭐️ Review point
(5번 브랜치 PR에서 헤드 따온거라 리뷰는 5번 머지 이후에 보면 더 편할거야!)
📷 Demo