변경된 홈 디자인과 바텀 시트를 구현합니다. #38
Conversation
There was a problem hiding this comment.
Pull Request Overview
Implements a redesigned home UI with animated bottom sheet functionality that randomly cycles through suggestion proposals.
- Added animated random proposal cycling with play/stop controls
- Updated home screen layout with personalized greeting and improved visual design
- Enhanced bottom sheet with automatic rotation and manual controls
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| RandomProposal.kt | Implements auto-rotating random proposals with animation and play/stop controls |
| HomeBottomSheet.kt | Updates bottom sheet to support multiple labels and play state management |
| GatheringsCard.kt | Adds conditional rendering for gatherings divider |
| HomeViewModel.kt | Adds member info fetching and updates proposal click handling with index parameter |
| HomeScreen.kt | Redesigns home layout with shake animation, personalized greeting, and improved spacing |
| HomeContract.kt | Updates state to include userName and changes propose action to include index |
| OnboardingService.kt | Adds endpoint for fetching member information |
| MemberInfoResponse.kt | New data model for member information response |
| GetMemberInfoUseCase.kt | New use case for retrieving member info |
| OnboardingRepository.kt | Adds getMemberInfo method to repository interface |
| MemberInfo.kt | New domain model for member information |
| strings.xml | Updates text resources with new home title and button labels |
| ic_stop.xml | New stop icon for pause functionality |
| ic_next_arrow_circle.xml | New arrow icon for proposal submission |
| SerifType.kt | Adds new title18M typography style |
| TopAppBar.kt | Extracts top app bar height as constant |
| Button.kt | Makes TukButton public and adds height parameter |
| OnboardingRepositoryImpl.kt | Implements getMemberInfo method |
| Member.kt | New mapper for member info data transformation |
Comments suppressed due to low confidence (1)
feature/home/src/main/java/com/plottwist/feature/home/HomeScreen.kt:116
- Add a space after 'if' for better code readability. Should be 'if (isPlayed)' following Kotlin style guidelines.
HomeSideEffect.NavigateToMyPageScreen -> {
| .clip(CircleShape) | ||
| // .clickable { | ||
| // onRefreshClick() | ||
| // } |
There was a problem hiding this comment.
Remove commented-out code instead of leaving it in the codebase. If this functionality might be needed later, consider using version control history or create a proper feature flag.
| // } |
| .clip(CircleShape) | ||
| // .clickable { | ||
| // onRefreshClick() | ||
| // } |
There was a problem hiding this comment.
Remove commented-out code instead of leaving it in the codebase. If this functionality might be needed later, consider using version control history or create a proper feature flag.
| // } |
| .clip(CircleShape) | ||
| // .clickable { | ||
| // onRefreshClick() | ||
| // } |
There was a problem hiding this comment.
Remove commented-out code instead of leaving it in the codebase. If this functionality might be needed later, consider using version control history or create a proper feature flag.
| // } |
| onClick = { | ||
| onGatheringClick(gathering.gatheringId) | ||
| } | ||
| if(gatherings.gatheringOverviews.isNotEmpty()) { |
There was a problem hiding this comment.
Add a space after 'if' for better code readability. Should be 'if (gatherings.gatheringOverviews.isNotEmpty())' following Kotlin style guidelines.
| if(gatherings.gatheringOverviews.isNotEmpty()) { | |
| if (gatherings.gatheringOverviews.isNotEmpty()) { |
작업
스크린샷 or 영상
Screen_recording_20250810_192517.mp4