Skip to content

Conversation

@eshc123
Copy link
Member

@eshc123 eshc123 commented Jul 21, 2025

작업

  • core:ui-navigation 모듈을 새로 추가하고, Route sealed interface 및 기본 설정 파일 구성
  • feature:home 모듈을 생성하고, HomeScreen 및 HomeNavigation 구현
  • feature:main에 feature:home을 의존성으로 추가
  • 메인 UI(TukApp)에서 TukNavHost를 적용하여 네비게이션 구조 도입

참고사항

  • 이번 PR부터는 github-actions[bot] 리뷰를 막았습니다. copilot에 비해 도움되는 리뷰가 없지 않았나 싶어서 제외하였습니다.
  • ui-navigation 는 Route 모델을 관리하고 각 feature 모듈에서 ui-navigation의 Route를 바라보고 이동할 수 있도록 구성하였습니다.

@eshc123 eshc123 requested review from Copilot and ny2060 July 21, 2025 11:14
@eshc123 eshc123 self-assigned this Jul 21, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a navigation structure to the Android app by adding a new ui-navigation core module and implementing navigation components. The changes establish a centralized navigation system using Jetpack Compose Navigation with a sealed interface pattern for route management.

  • Added core:ui-navigation module with Route sealed interface for type-safe navigation
  • Created feature:home module with HomeScreen and navigation integration
  • Updated main feature to use TukNavHost instead of placeholder text
  • Configured build system to automatically include ui-navigation dependency in feature modules

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
settings.gradle.kts Added core:ui-navigation module to project structure
core/ui-navigation/* New navigation module with Route sealed interface and build configuration
feature/home/* New home feature module with screen and navigation components
feature/main/* Updated to integrate TukNavHost and removed placeholder text
build-logic/convention/src/main/kotlin/FeatureConventionPlugin.kt Added automatic ui-navigation dependency for feature modules
Comments suppressed due to low confidence (2)

core/ui-navigation/src/test/java/com/plottwist/core/ui/navigation/ExampleUnitTest.kt:12

  • The ui-navigation module contains only placeholder test files. Consider adding meaningful tests for the Route sealed interface and navigation functionality to ensure type safety and proper serialization behavior.
class ExampleUnitTest {

core/ui-navigation/src/androidTest/java/com/plottwist/core/ui/navigation/ExampleInstrumentedTest.kt:17

  • The ui-navigation module contains only placeholder instrumented test files. Consider adding integration tests to verify navigation behavior works correctly with the Android navigation framework.
class ExampleInstrumentedTest {

@@ -0,0 +1,12 @@
package com.plottwist.feature.home
Copy link

Copilot AI Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename 'HomeScree.kt' has a typo. It should be 'HomeScreen.kt' to match the HomeScreen component it contains.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@ny2060 ny2060 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 ~!

Base automatically changed from feature/add-main-module to dev July 22, 2025 10:13
@eshc123 eshc123 merged commit b72fd44 into dev Jul 22, 2025
1 check passed
@eshc123 eshc123 deleted the feature/add-navigation-to-home branch July 22, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants