Skip to content

Conversation

@eshc123
Copy link
Member

@eshc123 eshc123 commented Jul 21, 2025

작업

  • HomeScreen에 Orbit 적용해서 화면 구성
    • LoginScreen 이동 확인을 위해서 우측 상단에 마이페이지 버튼만 추가하였습니다.
  • 일부 모듈에 필요한 Convention Plugin 추가

스크린샷 or 영상

Screen_recording_20250721_213306.webm

@eshc123 eshc123 requested review from Copilot and ny2060 July 21, 2025 12:45
@eshc123 eshc123 self-assigned this Jul 21, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements navigation from the home screen to a login screen using the Orbit MVI pattern and adds necessary Convention Plugins for the project architecture.

  • Implements HomeScreen with Orbit MVI architecture including state management, actions, and side effects
  • Creates LoginScreen and establishes navigation flow between Home and Login screens
  • Adds new Convention Plugins for Hilt dependency injection and Compose setup across different module types

Reviewed Changes

Copilot reviewed 20 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
gradle/libs.versions.toml Updates plugin configurations by replacing generic hilt plugin with specific application/library variants
feature/main/* Integrates login navigation and adds Hilt support to MainActivity
feature/login/* Creates new login feature with screen and navigation setup
feature/home/* Implements Orbit MVI pattern with state management and navigation to login
core/ui/* Adds reusable StableImage component and applies new compose convention plugin
core/ui-navigation/* Adds Login route definition
core/designsystem/* Adds user icon drawable resource
build-logic/convention/* Creates new convention plugins for Hilt and Compose configurations
app/* Enables Hilt dependency injection
Comments suppressed due to low confidence (1)

core/ui/src/main/java/com/plottwist/core/ui/StableImage.kt:15

  • [nitpick] The parameter name 'description' should be 'contentDescription' to better reflect its purpose and align with Compose naming conventions for accessibility content descriptions.
    description : String? = null,

Base automatically changed from feature/add-navigation-to-home to dev July 22, 2025 10:13
@eshc123 eshc123 merged commit 59cedb0 into dev Jul 22, 2025
1 check passed
@eshc123 eshc123 deleted the feature/add-navigation-to-login branch July 22, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants