배치모듈 환경세팅 #7
Merged
배치모듈 환경세팅 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songyi00
reviewed
Jul 21, 2025
Collaborator
songyi00
left a comment
songyi00
left a comment
There was a problem hiding this comment.
빌드 실패하는 것만 확인해줘!!
고생했습니당 ㅎㅎ
| import org.springframework.stereotype.Component | ||
|
|
||
| @Component | ||
| class TukNotificationJob( |
Collaborator
There was a problem hiding this comment.
job은 최상위 레이어에 별도 패키지 따로 파서 관리하고 application은 재사용 가능한 서비스 코드만 넣는거 어떤가용?
Collaborator
There was a problem hiding this comment.
ㄴ job
ㄴ infra
ㄴ application
ㄴ 등등
| @Component | ||
| class MeetingNotificationSender( | ||
| private val memberService: MemberService, | ||
| private val fcmClient: FcmClient |
Collaborator
There was a problem hiding this comment.
요건 application <-> infra 의존성 역전이라 별도 어플리케이션 서비스로 한번 래핑해서 하위 인프라로 내리는게 나을 것 같습니다
그리고 저번에 얘기한 것처럼 tuk-api 에 별도 발송 API 따로 팔거라 그거로 추후 갈아껴야할 듯
|
|
||
| *.env | ||
| *.env | ||
| firebase-adminsdk.json |
Collaborator
There was a problem hiding this comment.
요거 파일로 직접 갖고 있지 말고 인코딩해서 압축한 후에 환경변수로 들고 있는건 어떤가요 애플리케이션 연결할땐 디코딩해서 사용하고!
따로 노출 위험 관리 부담도 적고 관리 포인트 줄어들 것 같아서용
Member
Author
There was a problem hiding this comment.
넵 FCM_ADMINSDK라는 이름의 환경변수에 저장해 뒀고 성공적으로 build 되는거 확인했습니다!
CD 환경에도 추가적으로 작업해둘게요
| import org.springframework.scheduling.quartz.SpringBeanJobFactory | ||
|
|
||
| @Configuration | ||
| class QuartzConfig( |
- MeetingNotificationService를 통해 바로 전송할건지 스케줄링할 것인지 결정 - MeetingNotifier 통해 Meeting 도메인에 해당하는 메시지를 생성하고 알림 - NotificatioSender를 구현한 FcmClient에서 실질적인 알림 전송이 이루어진다.
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What’s this PR?
📌 관련 이슈 (Related Issue)
🧶 주요 변경 내용 (Summary)
🧪 테스트 / 검증 내역
💬 기타 공유 사항
🙇🏻♀️ 리뷰 가이드 (선택)