[WIP] Fix issue 166 #191
Draft
[WIP] Fix issue 166 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by pip install .
enrich with file origine of the token. - Create the associated factory to instruct lexer to create token with our custom token The factory is responsible to use the file_line_map data. - Enrich CodePosition with fileName field.
This reverts commit a2c943d.
|
Tests are failing because hdlConvertorAst requiere an update of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Current draft push request is an attempt to fix : #166
First it remove new line added in preprocessing result. One part of the fix consist to make the preprocessing grammar to consume the training new line. The Ieee1800-2017 chapter 22.4 says
So we can remove new line on the line containing directive.
If included file does not end by new line, next line will appear on the last line from the included file. See tests/sv_pp/expected/include_many_dir/from_subdirectory.txt
Second part consist to enrich token build by antlr4 with original file location using
file_line_mapdata.But the result is not yet correct: current data structure does not allow to retrieve all information we need for every lines.
The CodePosition object has been update to reflect the
fileNamedata. hdlConvertorAst would also need to be updated.