Skip to content

Conversation

rowasc
Copy link

@rowasc rowasc commented Aug 1, 2019

Hey Nidhi! Sending this PR as a conversation starter on some ideas so we can discuss tomorrow

  • stopped using username and password with the password grant for anonymous users. Use a client_credentials grant instead (https://app.gitbook.com/@ushahidi/s/platform-developer-documentation/tech-stack-overview/api-documentation )
  • add .env.example so it's easy to see which variables can be configured
  • stopped using Person as it does not exist anymore
  • In this code example I stopped saving in localStorage , but you can bring it back of course and fix concerns around the following issues
    • when I reload, it should know if its the same form and deployment url before deciding to use the content from localstorage
    • the token should expire in local storage and Get a new one

Of course, you don't need to merge this, you can just grab some or none of these ideas, as you see fit (I am sending this in a PR for convenience since code is often a fast way to demo something).
It might be useful to ask me questions about the changes I am suggesting too!

fix(Form) fix sending form values as its done in platform client. Fix env values and make an env.example file as reference. Stop using a username and password
@rowasc rowasc changed the title Some ideas to make the form more resilient Some ideas to make the form more stable Aug 1, 2019
@rowasc rowasc force-pushed the suggestions-form-pwa branch from b77e7cd to 31f7390 Compare August 1, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant