Update Packages & SCSS #577
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@fortawesome/free-brands-svg-icons` had some minor bugfixes. `@tauri-apps/cli` updated some dependencies, had some minor bug fixes, and added new feature support for macOS and iOS. `@types/node` doesn't document their changes, but if they follow SemVer correctly, then there were no breaking changes. `gpt-tokenizer` had some bug fixes and added the new models. `postcss` had some minor bug fixes and improved an error message. `sass` had several bug fixes, and a few minor improvements. A couple of changes were considered potentially breaking, but mostly around obscure bugs/"features". @import and global built-ins have been deprecated since before 1.81.0. `uuid` fixed some minor bugs and allowed UInt8Array's instead of Buffer's.
SCSS was giving warnings about the use of @include. The only thing being included was Bulma. In the interest of ensuring Bulma was up to date with SCSS' expectations, it was also updated to the latest. bulma-prefers-dark was also removed, as it is supported by default in Bulma now. In the interest of getting things updated, the file was set to use the UTF-8 charset, this included adding the UTF-8 BOM to the file. This does result in a change in UI colors, since some were adjusted. Notably the info color remains bound to cyan, but the definition for cyan was updated from a cyan-blue to be closer to cyan. There are other minor changes, but overall, the UI is still functional.
The selector `.menu-list a, .menu-list button, .menu-list item` was updated to set the width to 100%. This broke the placement of these icons, and we just manually set them back to width auto.
hyfloac
force-pushed
the
update-packages
branch
2 times, most recently
from
f58a0fa to
f0b2fda
Compare
These weren't actually used anywhere. They were only causing conflicts with browser typings when I tried fixing the VS Code warnings about using any. A notable difference is with the return type of `setTimeout`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about getting some non-breaking packages updated, and fixing the SCSS warnings (a part of completing some of the updates).
I have other changes already made, and more changes I'd like to make, but in the interest of keeping PRs isolated, I've cherry-picked this part out.
Updated a handful of packages.
@fortawesome/free-brands-svg-iconshad some minor bugfixes.@tauri-apps/cliupdated some dependencies, had some minor bug fixes, and added new feature support for macOS and iOS.@types/nodedoesn't document their changes, but if they follow SemVer correctly, then there were no breaking changes.I changed to simply removing this. It wasn't being used for any types, and it introduces some types that differ from the browser, which just creates confusion about the type guidance.gpt-tokenizerhad some bug fixes and added the new models.postcsshad some minor bug fixes and improved an error message.sasshad several bug fixes, and a few minor improvements. A couple of changes were considered potentially breaking, but mostly around obscure bugs/"features". @import and global built-ins have been deprecated since before 1.81.0.uuidfixed some minor bugs and allowed UInt8Array's instead of Buffer's.Removed SCSS warnings
SCSS was giving warnings about the use of @include.
The only thing being included was Bulma. In the interest of ensuring Bulma was up to date with SCSS' expectations, it was also updated to the latest.
bulma-prefers-dark was also removed, as it is supported by default in Bulma now.
In the interest of getting things updated, the file was set to use the UTF-8 charset, this included adding the UTF-8 BOM to the file.
This does result in a change in UI colors, since some were adjusted. Notably the info color remains bound to cyan, but the definition for cyan was updated from a cyan-blue to be closer to cyan.
There are other minor changes, but overall, the UI is still functional.
I did have to implement a fix for the edit and delete buttons, as they were left shifted due to a rule which had set their width to 100%, it is now set back to auto.