Skip to content

Conversation

@bbarker
Copy link
Contributor

@bbarker bbarker commented Feb 11, 2025

This has been tested on NixOS (Linux), non-NixOS Linux, and MacOS (intel).

@bbarker
Copy link
Contributor Author

bbarker commented May 16, 2025

👋 I've been using this for a while on my project, and no issues to speak of

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file required? I would prefer not to have to update the repo with every new rust version.

Copy link
Contributor Author

@bbarker bbarker May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. Let me try to modify this in the next few days, so it is optional.

I'm also trying to update the template to 0.16 in another branch - just mentioning it as I haven't done a whole lot yet, but don't want to duplicate effort. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it wasn't too bad to do the 0.16 update, so i'll submit a PR in a second for that.

But I realized I also need to add nixGL support to this flake.nix, which is in my project, but not in the template currently (otherwise it builds but doesn't run, on non-NixOS linux with nix).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the toolchain file to be under nix/ so that it doesn't interfere with non-nix users. It is pretty typical in Nix to have things pinned. Had a few other updates to do related to bevy 0.16 (and thus rust edition 2024) support. But I tested it and it runs now.

Copy link
Contributor Author

@bbarker bbarker May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is rebased on bevy_main though, currently - should I change the target branch to bevy_main?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty confused by the diff. The PR seems to target the main branch, which is correct, but the diff does not seem up to date. Could you merge main into this PR? The main branch already uses Bevy 0.16.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NiklasEi , that was peculiar - a (thankfully trivial) rebase seems to have fixed it though

@bbarker
Copy link
Contributor Author

bbarker commented May 27, 2025

Just a bump to note this seems to be working, but see comment about target branch: #127 (comment)

Copy link
Owner

@NiklasEi NiklasEi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂

@NiklasEi NiklasEi merged commit 0570682 into NiklasEi:main Jul 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants