-
Notifications
You must be signed in to change notification settings - Fork 107
add flake.nix #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flake.nix #127
Conversation
|
👋 I've been using this for a while on my project, and no issues to speak of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file required? I would prefer not to have to update the repo with every new rust version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. Let me try to modify this in the next few days, so it is optional.
I'm also trying to update the template to 0.16 in another branch - just mentioning it as I haven't done a whole lot yet, but don't want to duplicate effort. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it wasn't too bad to do the 0.16 update, so i'll submit a PR in a second for that.
But I realized I also need to add nixGL support to this flake.nix, which is in my project, but not in the template currently (otherwise it builds but doesn't run, on non-NixOS linux with nix).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the toolchain file to be under nix/ so that it doesn't interfere with non-nix users. It is pretty typical in Nix to have things pinned. Had a few other updates to do related to bevy 0.16 (and thus rust edition 2024) support. But I tested it and it runs now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is rebased on bevy_main though, currently - should I change the target branch to bevy_main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty confused by the diff. The PR seems to target the main branch, which is correct, but the diff does not seem up to date. Could you merge main into this PR? The main branch already uses Bevy 0.16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NiklasEi , that was peculiar - a (thankfully trivial) rebase seems to have fixed it though
|
Just a bump to note this seems to be working, but see comment about target branch: #127 (comment) |
NiklasEi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙂
This has been tested on NixOS (Linux), non-NixOS Linux, and MacOS (intel).