Skip to content

Conversation

jcabrero
Copy link
Member

No description provided.

@jcabrero jcabrero force-pushed the feat/nilauth-credit branch from d639b2f to a47a535 Compare October 10, 2025 10:20
@jcabrero jcabrero changed the base branch from feat/nilauth-credit to main October 10, 2025 10:21
@jcabrero jcabrero changed the base branch from main to feat/nilauth-credit October 10, 2025 10:28
@jcabrero jcabrero changed the title chore: refactor nilAI before forking to nilAgent chore: removed nilai-auth and moved nuc-helpers to nilai_api/auth Oct 10, 2025
@jcabrero jcabrero requested a review from Copilot October 10, 2025 15:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates authentication code by removing the standalone nilai-auth project and nuc-helpers package, moving the nuc-helpers functionality into nilai_api/auth/nuc_helpers directory. The change also removes JWT authentication support while retaining NUC (Nillion User Compute) token authentication.

  • Removed entire nilai-auth directory containing auth server, client, and helpers
  • Moved nuc-helpers code to nilai_api/auth/nuc_helpers
  • Updated all import statements to reference the new location

Reviewed Changes

Copilot reviewed 26 out of 36 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/unit/nuc_helpers/test_usage.py Updated imports to use new nilai_api.auth.nuc_helpers.usage path
tests/unit/nuc_helpers/test_nildb_document.py Updated import for PromptDocument to new location
tests/unit/nilai_api/auth/test_strategies.py Removed JWT strategy tests and updated imports
tests/unit/nilai_api/auth/test_jwt.py Deleted entire JWT test file
tests/e2e/nuc.py Updated imports to use new nuc_helpers location
pyproject.toml Removed nuc-helpers dependency and nilai-auth workspace members
nilai-auth/* Removed entire nilai-auth directory and all subprojects
nilai-api/src/nilai_api/auth/strategies.py Removed JWT strategy implementation
nilai-api/src/nilai_api/auth/nuc_helpers/* Updated internal imports to reference new module structure
nilai-api/src/nilai_api/auth/jwt.py Deleted JWT authentication implementation
nilai-api/src/nilai_api/auth/common.py Updated imports for nuc_helpers types
nilai-api/src/nilai_api/auth/init.py Updated import for UsageLimitError
nilai-api/pyproject.toml Removed nuc-helpers dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant