chore: refactor remove unused containers #160
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused container services and their associated configurations from the project. The main purpose is to clean up monitoring infrastructure and attestation services that are no longer needed.
- Removes the entire
nilai-attestationservice including all Python code, tests, Go modules, and configuration - Removes monitoring infrastructure including Prometheus configuration and Grafana routing
- Removes container definitions for
prometheus,node_exporter,grafana, andattestationservices from Docker Compose
Reviewed Changes
Copilot reviewed 24 out of 36 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| prometheus/config/prometheus.yml | Removes Prometheus configuration file entirely |
| nilai-attestation/ | Removes complete attestation service directory including Python code, tests, Go modules |
| docker-compose.yml | Removes monitoring containers (prometheus, node_exporter, grafana, attestation) |
| docker-compose.*.yml | Removes attestation and monitoring service configurations from production/dev environments |
| caddy/Caddyfile.http | Removes Grafana proxy routing configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
70
to
+76
| grafana: | ||
| container_name: grafana | ||
| image: 'grafana/grafana:11.5.1' | ||
| restart: unless-stopped | ||
| user: "$UID:$GID" | ||
| depends_on: | ||
| - prometheus | ||
| environment: | ||
| - GF_USERS_ALLOW_SIGN_UP=false | ||
| healthcheck: | ||
| test: ["CMD", "curl", "-f", "http://localhost:3000/api/health"] | ||
| interval: 30s | ||
| timeout: 10s | ||
| retries: 3 | ||
| start_period: 10s |
There was a problem hiding this comment.
The grafana service has a dependency on prometheus service, but prometheus service has been removed from the main docker-compose.yml file. This will cause the grafana container to fail to start.
Copilot uses AI. Check for mistakes.
jcabrero
force-pushed
the
chore/refactor
branch
from
a9e60ab to
b89c8e5
Compare
jcabrero
force-pushed
the
chore/refactor_removed_useless_containers
branch
from
f142e44 to
a27de4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.