Skip to content

Conversation

@alexgithublab
Copy link
Collaborator

No description provided.

@github-actions
Copy link

The successful documentation build was deployed for preview:

@daringer
Copy link
Contributor

nice, some minor things - also not entirely related to this PR, but on this page (based on this: https://docspreview.nitrokey.com/PR-438/software/nk-app2/keepassxc)

  • make sure the structure is correct (see table of contents on the right side) the "Troubleshooting" section should be in the same hierarchy as "First Step"
  • "First and Second Option" should be below "First Step"
  • the "note" and "warning" at the upper part of the article have incorrect indents (see https://github.com/Nitrokey/nitrokey-documentation?tab=readme-ov-file#indents)
  • also feel free to include the necessary CI fix

@mmerklinger
Copy link
Member

I fixed the CI pipeline. Please rebase on main branch.

@github-actions
Copy link

The successful documentation build was deployed for preview:

* Fix enumerated start value errors

---------

Co-authored-by: jans23 <[email protected]>
@github-actions
Copy link

The successful documentation build was deployed for preview:

@alexgithublab
Copy link
Collaborator Author

Thank you, I'm not sure why I get theses errors while I'm not getting it locally.

Is rstcheck_core version 1.2.1 or higher ?

@github-actions
Copy link

The successful documentation build was deployed for preview:

@mmerklinger
Copy link
Member

You should be able to see them locally as well. Maybe your VENV isn't up to date? Delete it with rm -r ./venv and then run make check again. It should automatically rebuild the VENV. Fixed the errors for you.

@daringer
Copy link
Contributor

daringer commented May 5, 2025

ReST is so picky about indents:
https://docspreview.nitrokey.com/PR-438/software/nk-app2/keepassxc#pcscd-card-not-found

please make sure those two code blocks are correctly rendered

@github-actions
Copy link

github-actions bot commented May 6, 2025

The successful documentation build was deployed for preview:

@daringer daringer merged commit a48004f into main May 7, 2025
2 checks passed
@daringer daringer deleted the passxc branch May 7, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants