Skip to content

Conversation

@alexgithublab
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented May 5, 2025

The successful documentation build was deployed for preview:

@jans23
Copy link
Member

jans23 commented May 5, 2025

This doesn't look right to me. The last line with bullet point is different than the other entries.

@alexgithublab
Copy link
Collaborator Author

yes this is a way to fix the structure problem

@daringer
Copy link
Contributor

daringer commented May 5, 2025

this also remove the item from the navigation on the right, but this is ok and even good as it's bad to have two entries in the navigation which point to the same article (only one of them will be highlighted as active).

I'd suggest to make this differentiation clear here, just add something like:

### OpenPGP Card Features 
The Nitrokey HSM is essentially a more potent OpenPGPCard, thus some of the OpenPGPCard features are also applicable for the HSM - although might need some adjustments.

* `Hard Disk Encryption <../openpgp-card/hard-disk-encryption/index.html>`_

like this:

  • we get rid of the double navigation problem for this item
  • we make it clear that the following items are actually OpenPGPCard features, which also apply to the Nitrokey HSM

@alexgithublab
Copy link
Collaborator Author

About first part of your message:
No I think is a bug bc of #442 when I build locally I still have the entry in the left list (you said right btw)

About the 2nd part: I'll check this

@github-actions
Copy link

github-actions bot commented May 6, 2025

The successful documentation build was deployed for preview:

@github-actions
Copy link

The successful documentation build was deployed for preview:

@github-actions
Copy link

The successful documentation build was deployed for preview:

@jans23 jans23 merged commit c009c85 into main May 16, 2025
2 checks passed
@jans23 jans23 deleted the structure branch May 16, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants