Skip to content

queue runner: attempt at slightly smarter scheduling criteria #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Apr 20, 2025

(cherry picked from commit https://git.lix.systems/lix-project/hydra/commit/b8d03adaf45105452bf1040deeaaccc8b8b22efb)

@mweinelt Was this commit ever tried on h.n.o?

Instead of just going for "whatever is the oldest build we know of",
use the following first:

- Is the step more constrained? If so, schedule it first to avoid
  filling up "more desirable" build slots with less constrained builds.

- Does the step have more dependents? If so, schedule it first to try
  and maximize open parallelism and breadth of scheduling options.

(cherry picked from commit https://git.lix.systems/lix-project/hydra/commit/b8d03adaf45105452bf1040deeaaccc8b8b22efb)
@mweinelt
Copy link
Member

I don't think it was.

Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principle. However someone would need to take the time to watch the graphs in NixOS infra after this patch was applied. @zowoq have you tried this out by chance?

@zowoq
Copy link
Contributor Author

zowoq commented May 1, 2025

Yes, used this on the community hydra for a while before switching back to upstream but that probably doesn't help much as the workloads are too different.

@mweinelt
Copy link
Member

mweinelt commented May 1, 2025

I think its worth giving it a try on hno.

@Mic92 Mic92 added this pull request to the merge queue May 1, 2025
Merged via the queue into NixOS:master with commit 1b5c2fb May 1, 2025
1 check passed
@zowoq zowoq deleted the queue-runner branch May 1, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants