Realisations use regular drv paths again #12464
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new-cli
Ericson2314
force-pushed
the
build-trace-rework
branch
from
6f610de to
be5cfe4
Compare
github-actions
bot
added
the
fetching
Ericson2314
force-pushed
the
build-trace-rework
branch
from
be5cfe4 to
7b01c8b
Compare
Ericson2314
force-pushed
the
build-trace-rework
branch
from
7b01c8b to
546d826
Compare
Ericson2314
force-pushed
the
build-trace-rework
branch
3 times, most recently
from
a031df7 to
4f9435b
Compare
Ericson2314
force-pushed
the
build-trace-rework
branch
from
4f9435b to
46fde9b
Compare
Ericson2314
force-pushed
the
build-trace-rework
branch
from
46fde9b to
d150215
Compare
Ericson2314
force-pushed
the
build-trace-rework
branch
4 times, most recently
from
9f3fdcf to
c9ac039
Compare
Ericson2314
changed the title
Ericson2314
force-pushed
the
build-trace-rework
branch
7 times, most recently
from
e0eb7f7 to
aa43f8d
Compare
Ericson2314
force-pushed
the
build-trace-rework
branch
from
aa43f8d to
043eed8
Compare
Ericson2314
force-pushed
the
build-trace-rework
branch
6 times, most recently
from
c4d6eb8 to
5b3977f
Compare
Ericson2314
force-pushed
the
build-trace-rework
branch
from
5b3977f to
170b0bf
Compare
Ericson2314
force-pushed
the
build-trace-rework
branch
7 times, most recently
from
895e576 to
7c90246
Compare
|
🎉 All dependencies have been resolved ! |
1 similar comment
|
🎉 All dependencies have been resolved ! |
xokdvium
reviewed
Dec 17, 2025
Ericson2314
commented
Dec 17, 2025
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Dec 17, 2025
While working on NixOS#12464, I realized this method was not correct in this case. With the current binary cache format, it is harmless, since we don't create arbitrary directories, but with my change, we started to. Regardless of whether we need it or not, I think it is better if the function just does the right thing.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Dec 17, 2025
While working on NixOS#12464, I realized this method was not correct in this case. With the current binary cache format, it is harmless, since we don't create arbitrary directories, but with my change, we started to. Regardless of whether we need it or not, I think it is better if the function just does the right thing.
Ericson2314
force-pushed
the
build-trace-rework
branch
2 times, most recently
from
0170fb3 to
4be3aea
Compare
Member
|
I applied an earlier version of this PR https://github.com/Mic92/nix-1/tree/broken-main |
Member
|
when I applied this pr, After dropping the patches from my fork, it does again. This happened with all nix versions I tested btw, while the faulty version was running as the nix-daemon. |
Draft
Ericson2314
force-pushed
the
build-trace-rework
branch
from
4be3aea to
4cf2e4f
Compare
Extract the logic for determining whether a derivation should be resolved before building into a dedicated method. Then use that to not resolve unnecessarily in `nix-shell`.
Fix NixOS#11897 As described in the issue, this makes for a simpler and much more intuitive notion of a realisation key. This is better for pedagogy, and interoperability between more tools. The way the issue was written was that we would switch to only having shallow realisations first, and then do this. But going to only shallow realisations is more complex change, and it turns out we weren't even testing for the benefits that derivation hashes (modulo FODs) provided in the deep realisation case, so I now just want to do this first. Doing this gets the binary cache data structures in order, which will unblock the Hydra fixed-output-derivation tracking work. I don't want to delay that work while I figure out the changes needed for shallow-realisations only. This reverts commit bab1cda.
Ericson2314
force-pushed
the
build-trace-rework
branch
from
4cf2e4f to
d9e2cd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #11897
As described in the issue, this makes for a simpler and much more intuitive notion of a realisation key. This is better for pedagogy, and interoperability between more tools.
Context
The way the issue was written was that we would switch to only having shallow realisations first, and then do this. But going to only shallow realisations is more complex change, and it turns out we weren't even testing for the benefits that derivation hashes (modulo FODs) provided in the deep realisation case, so I now just want to do this first.
Doing this gets the binary cache data structures in order, which will unblock the Hydra fixed-output-derivation tracking work. I don't want to delay that work while I figure out the changes needed for shallow-realisations only.
Revert "Use the hash modulo in the derivation outputs"
This reverts commit bab1cda.
Depends on #14247
Depends on #14257
Depends on #14648
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.