Improve line wrapping and width handling#256
Merged
piegamesde merged 1 commit intoNixOS:masterfrom Dec 2, 2024
Merged
Conversation
infinisil
approved these changes
Oct 1, 2024
Member
infinisil
left a comment
infinisil
left a comment
There was a problem hiding this comment.
LGTM (but needs a better commit message and maybe code comments before we can merge this)
Member
Author
- enable = mkEnableOption "Suwayomi, a free and open source manga reader server that runs extensions built for Tachiyomi";
+ enable =
+ mkEnableOption "Suwayomi, a free and open source manga reader server that runs extensions built for Tachiyomi";Doesn't look good to me at all tbh |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2024-10-01/53763/1 |
piegamesde
force-pushed
the
line-wrapping
branch
2 times, most recently
from
047a810 to
fffa53c
Compare
This partially addresses NixOS#255
piegamesde
force-pushed
the
line-wrapping
branch
from
fffa53c to
a02e0a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #255