Skip to content

framework-intel-core-ultra-series1: preset device name for audio enhancement #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

anna-oake
Copy link
Contributor

@anna-oake anna-oake commented Jul 7, 2025

Description of changes

There is an awesome audio enhancement feature in the Framework 13 profiles.

On framework-13-7040-amd it can be enabled by setting hardware.framework.laptop13.audioEnhancement = true;.
On framework-intel-core-ultra-series1, however, this is not enough, because the raw audio device name is not preconfigured in the profile.

This PR adds the device name the same way it's done in the AMD profile.

⚠️ I don't know if there was a specific reason not to do this in the first place. Could it be that these Intel laptops have varying device names? I only have one laptop of this kind to test this with.

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@0x4A6F
Copy link
Member

0x4A6F commented Jul 16, 2025

They seem identical for the intel framework models, where there are defined. Afaik Mic92 reached out to maintainers of these models.

$ rg alsa_output framework/
framework/13-inch/amd-ai-300-series/default.nix
14:    lib.mkDefault "alsa_output.pci-0000_c1_00.6.analog-stereo";

framework/13-inch/11th-gen-intel/default.nix
15:    lib.mkDefault "alsa_output.pci-0000_00_1f.3.analog-stereo";

framework/13-inch/7040-amd/default.nix
44:      lib.mkDefault "alsa_output.pci-0000_c1_00.6.analog-stereo";

framework/13-inch/12th-gen-intel/default.nix
13:        lib.mkDefault "alsa_output.pci-0000_00_1f.3.analog-stereo";

framework/13-inch/common/audio.nix
50:        example = "alsa_output.pci-0000_c1_00.6.analog-stereo";

For unmaintained models hardware.framework.laptop13.rawDeviceName could be used.

@0x4A6F 0x4A6F added this pull request to the merge queue Jul 16, 2025
Merged via the queue into NixOS:master with commit d1bfa8f Jul 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants