openmpi: patch for legitimate zero size messages #14445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is required in order to make python-mpi4py tests pass. It is also a bug in the openmpi implementation to see full discussion see https://www.open-mpi.org/community/lists/users/2015/11/28030.php
|
By analyzing the blame information on this pull request, we identified @rbvermaa, @abbradar and @aherrmann to be potential reviewers |
|
The error was "The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over)." Should I turn down the verbosity of tests and compiling? (not sure how to do) It is also building the mpi4py package which it does not depend on why is that? (At least what I saw from the logs) |
|
Eh, looks good to me. Ignore travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done:
nix-build --option build-use-chroot trueor nix.useChroot on NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)More
This patch is required in order to make python-mpi4py tests pass.
It is also a bug in the openmpi implementation to see full discussion
see https://www.open-mpi.org/community/lists/users/2015/11/28030.php
I will be releasing an python-mpi4py change that depends on this patch.
Please note that this patch will NOT be required when openmpi upgrades to 2.0.0.