Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grin: 1.2.1 -> 1.3.0 #148789

Merged
merged 1 commit into from
Dec 6, 2021
Merged

grin: 1.2.1 -> 1.3.0 #148789

merged 1 commit into from
Dec 6, 2021

Conversation

sjagoe
Copy link
Member

@sjagoe sjagoe commented Dec 5, 2021 •
edited
Loading

#148779 cc @piegamesde .

Motivation for this change

Update grin to Python 3 compatible version.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@sjagoe
grin: 1.2.1 -> 1.3.0
84e6d5b 
Update grin to Python 3 compatible version (NixOS#148779)
@piegamesde piegamesde mentioned this pull request Dec 5, 2021
Closed
jonringer
jonringer approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 148789 run on x86_64-linux 1

1 package built:
  • grin

@jonringer jonringer merged commit 424599f into NixOS:master Dec 6, 2021
@sjagoe sjagoe deleted the pkg/grin branch December 6, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjagoe @jonringer